[
https://issues.apache.org/jira/browse/TINKERPOP-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18034088#comment-18034088
]
ASF GitHub Bot commented on TINKERPOP-3186:
-------------------------------------------
xiazcy commented on code in PR #3257:
URL: https://github.com/apache/tinkerpop/pull/3257#discussion_r2476421403
##########
gremlin-dotnet/src/Gremlin.Net/Structure/IO/GraphSON/EdgeDeserializer.cs:
##########
@@ -45,7 +45,7 @@ public dynamic Objectify(JsonElement graphsonObject,
GraphSONReader reader)
? labelProperty.GetString()!
: "edge";
- dynamic[]? properties = null;
+ dynamic[] properties = System.Array.Empty<dynamic>();
Review Comment:
Will do, thanks Valentyn!
> Inconsistency of properties data type on Element
> ------------------------------------------------
>
> Key: TINKERPOP-3186
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3186
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
> Affects Versions: 3.7.4
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Blocker
> Labels: breaking
>
> The {{properties}} property on {{Element}} in javascript has datatypes
> inconsistent with Java and other GLVs where it can be a {{Map}}, {{List}} or
> {{undefined}} depending on serializer or other factors (and we go through
> great lengths to assert all of this in tests for some reason). The type
> should be {{List}}. Use an empty list if {{null}} or {{undefined}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
