[
https://issues.apache.org/jira/browse/TINKERPOP-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18043700#comment-18043700
]
ASF GitHub Bot commented on TINKERPOP-3219:
-------------------------------------------
Cole-Greer commented on PR #3285:
URL: https://github.com/apache/tinkerpop/pull/3285#issuecomment-3629588426
+1 to Andrea's question above. Unless there are other justifications I'm not
aware of, I would be more in favour of updating `makeBytecodeRequest()`,
`makeStringRequest()`, `serializeMessage()`, and `deserializeMessage()`
publicly accessible of wrapping them here. If we think that those methods
don't provide a convenient interface for external usage, I would prefer to add
dedicated public methods to `graphBinary.go` and `request.go` which are more
usable.
> Add public serialization API in gremlin-go for alternative transport protocols
> ------------------------------------------------------------------------------
>
> Key: TINKERPOP-3219
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3219
> Project: TinkerPop
> Issue Type: Improvement
> Components: go
> Affects Versions: 4.0.0, 3.8.1
> Reporter: Haiyu Wang
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0, 3.8.1
>
>
> Currently, gremlin-go only supports WebSocket transport. The serialization
> logic (GraphBinary) is internal/private, preventing developers from building
> custom transport implementations (gRPC, HTTP/2, etc.) while maintaining
> Gremlin API compatibility.
> This improvement adds a new file gremlin-go/driver/serializer_export.go with
> 5 exported wrapper functions around existing internal serialization logic:
> - SerializeRequest() - Serialize bytecode with traversal source
> - SerializeBytecode() - Convenience wrapper using default source
> - SerializeStringQuery() - Serialize string queries
> - DeserializeResult() - Deserialize response bytes
> - NewResultSet() - Create ResultSet from collected results
> These are thin wrappers with zero modifications to existing code, fully
> backward compatible, and enable the ecosystem to build alternative transports.
> Use case: Building gRPC-based Gremlin clients for production deployments.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
