[ 
https://issues.apache.org/jira/browse/TINKERPOP-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18057409#comment-18057409
 ] 

ASF GitHub Bot commented on TINKERPOP-2992:
-------------------------------------------

spmallette commented on code in PR #3303:
URL: https://github.com/apache/tinkerpop/pull/3303#discussion_r2783893903


##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/language/translator/JavascriptTranslateVisitor.java:
##########
@@ -38,6 +38,8 @@
  *     <li>Makes anonymous traversals explicit with double underscore</li>
  *     <li>Makes enums explicit with their proper name</li>
  * </ul>
+ * <p/>
+ * Assumes use of https://www.npmjs.com/package/uuid library for UUID handling.

Review Comment:
   we were already committed to using `uuid` though: 
https://github.com/apache/tinkerpop/blob/3.8.0/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/language/translator/JavascriptTranslateVisitor.java#L222
 
   
   all i did was use the `parse` mechanism for a defined uuid. i suppose we 
could remove the translation wholly? but then a part of Gremlin doesn't work 
which now has a `uuid()` function. 





> Gherkin suite missing orderability on set, uuid, date
> -----------------------------------------------------
>
>                 Key: TINKERPOP-2992
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2992
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: test-suite
>    Affects Versions: 3.6.5
>            Reporter: Stephen Mallette
>            Priority: Minor
>
> Orderability.feature has todos in it for set, uuid and date.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to