Cole Greer created TINKERPOP-3242:
-------------------------------------

             Summary: Pull Configuring interface into VertexStepContract and 
GraphStepContract
                 Key: TINKERPOP-3242
                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3242
             Project: TinkerPop
          Issue Type: Improvement
          Components: process
    Affects Versions: 3.8.1, 3.8.0
            Reporter: Cole Greer
            Assignee: Cole Greer


The StepContracts for GraphStep and VertexStep do not extend `Configuring`, 
despite the concrete step implementation already doing so and accepting 
`with()` configurations.

Step implementations should not be added extra interfaces which are not present 
in the StepContract. We should pull the `Configuring` interface into 
VertexStepContract and GraphStepContract, and implement the missing methods in 
VertexStepPlaceholder and GraphStepPlaceholder. Neither of the StepPlaceholders 
should perform any actions on the Parameters, they should merely be stored to 
be passed onto the eventual concrete step. The use of withConfiguration 
Parameters in AbstractAddElementStepPlaceholder can be used as an example.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to