[
https://issues.apache.org/jira/browse/TINKERPOP-3250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18088373#comment-18088373
]
ASF GitHub Bot commented on TINKERPOP-3250:
-------------------------------------------
kenhuuu commented on code in PR #3447:
URL: https://github.com/apache/tinkerpop/pull/3447#discussion_r3399102017
##########
gremlin-python/src/main/python/gremlin_python/driver/connection.py:
##########
@@ -34,17 +35,23 @@ def __init__(self, status):
class Connection:
def __init__(self, url, traversal_source,
- executor, pool, request_serializer=None,
+ executor, pool,
response_serializer=None, auth=None, interceptors=None,
headers=None, enable_user_agent_on_connect=True,
bulk_results=False, **transport_kwargs):
if callable(interceptors):
interceptors = [interceptors]
- elif not (isinstance(interceptors, tuple)
- or isinstance(interceptors, list)
- or interceptors is None):
+ elif isinstance(interceptors, tuple):
+ interceptors = list(interceptors)
+ elif not (isinstance(interceptors, list) or interceptors is None):
raise TypeError("interceptors must be a callable, tuple, list or
None")
+ # Auth is just an interceptor. As a convenience (and for
discoverability), the auth
Review Comment:
I think we should actually do the opposite. Each GLV should have a way to
add an auth to help with discoverability. Otherwise, users might not understand
how to add the default Auth interceptors.
> Modify default request serialization to JSON
> --------------------------------------------
>
> Key: TINKERPOP-3250
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3250
> Project: TinkerPop
> Issue Type: Improvement
> Reporter: Ken Hu
> Priority: Major
>
> Changing the default request serialization is more aligned to how most HTTP
> APIs operate and will allow for easier debugging. This is especially true for
> applications that will rely on interceptors as it is difficult to see what
> the serialized bytes are for GraphBinary.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
