[
https://issues.apache.org/jira/browse/TINKERPOP-3275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18097999#comment-18097999
]
ASF GitHub Bot commented on TINKERPOP-3275:
-------------------------------------------
codecov-commenter commented on PR #3539:
URL: https://github.com/apache/tinkerpop/pull/3539#issuecomment-5040545866
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/3539?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 76.99%. Comparing base
([`4722890`](https://app.codecov.io/gh/apache/tinkerpop/commit/4722890ed831ba4f71c3916b5e6eafcf85439345?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`0979fd0`](https://app.codecov.io/gh/apache/tinkerpop/commit/0979fd0b0c6ebc081107661484fc75ac9f10e3e4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 25 commits behind head on 3.7-dev.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.7-dev #3539 +/- ##
=============================================
+ Coverage 75.49% 76.99% +1.49%
=============================================
Files 1092 28 -1064
Lines 67208 5330 -61878
Branches 7391 0 -7391
=============================================
- Hits 50742 4104 -46638
+ Misses 13837 1023 -12814
+ Partials 2629 203 -2426
```
</details>
[:umbrella: View full report in Codecov by
Harness](https://app.codecov.io/gh/apache/tinkerpop/pull/3539?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> gremlin-python graphbinary BigInt serializer incorrect for negative boundary
> values
> -----------------------------------------------------------------------------------
>
> Key: TINKERPOP-3275
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3275
> Project: TinkerPop
> Issue Type: Bug
> Components: python
> Affects Versions: 3.7.6, 3.8.1
> Reporter: Ken Hu
> Priority: Major
>
> Caveat: I haven't fully verified this, just something AI told me when I was
> updating the "model" tests for gremlin-python. Just putting here so it can be
> checked later.
> gremlin-python can't serialize BigInt signed boundary values like -129.
> {code:java}
> The failure path is:
> GraphBinaryWriter.write_object()
> BigIntIO.dictify()
> BigIntIO.write_bigint()
> obj.to_bytes(length, byteorder='big', signed=True)
> {code}
> For -129, Python reports:
> (-129).bit_length() == 8
> The current writer computes:
> length = (obj.bit_length() + 7) // 8 # 1
> But one signed byte only represents -128 through 127, so -129 needs two bytes
> in two’s complement form. The serializer is using magnitude bit length as if
> it were signed encoded length.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
