[ 
https://issues.apache.org/jira/browse/TINKERPOP-3185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18098247#comment-18098247
 ] 

ASF GitHub Bot commented on TINKERPOP-3185:
-------------------------------------------

kirill-stepanishin opened a new pull request, #3545:
URL: https://github.com/apache/tinkerpop/pull/3545

   https://issues.apache.org/jira/browse/TINKERPOP-3185
   
   In the Python driver, `PeerPressure.property_name` pointed at the wrong 
value, a `pageRank` token instead of a `peerPressure`.
   
   Because of this, `peerPressure().with_(PeerPressure.property_name, ...)` 
silently ignored the setting. This fix corrects the value to match Java and the 
other GLVs.
   
   I also checked the other `with()` constants across all GLVs, and this was 
the only mismatch.




> Ensure consistency of option key constants for with()
> -----------------------------------------------------
>
>                 Key: TINKERPOP-3185
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3185
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: dotnet, go, javascript, process, python
>    Affects Versions: 3.7.4
>            Reporter: Cole Greer
>            Priority: Trivial
>
> There are inconsistencies across GLVs in some of the constants intended to 
> use for with() modulation. One such example is PeerPressure.py in python 
> incorrectly using a pagerank constant: 
> https://github.com/apache/tinkerpop/blob/5030841548e6da924a71fa39153ef829573de855/gremlin-python/src/main/python/gremlin_python/process/traversal.py#L661
> That inconsistency should be fixed, as well as all other similar classes 
> verified for correctness.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to