[
https://issues.apache.org/jira/browse/TINKERPOP-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18120339#comment-18120339
]
ASF GitHub Bot commented on TINKERPOP-2363:
-------------------------------------------
Cole-Greer commented on PR #3672:
URL: https://github.com/apache/tinkerpop/pull/3672#issuecomment-5877319459
I think this fix is fine targeting 3.7-dev. I agree it's technically a
breaking change, but the impact is limited to cases which formerly threw
exceptions now working with the auto-promotion behaviour.
Master does indirectly re-implement the same semantics as this PR via
`GremlinLang`, making this fix a no-op there.
I'm happy to introduce the fix early in 3.7.x and 3.8.x to get it in users
hands earlier. This has been an annoyance for python users for quite some time,
and I think it's low risk to introduce in a minor release.
VOTE +1
> GraphBinary and numerics for Python
> -----------------------------------
>
> Key: TINKERPOP-2363
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2363
> Project: TinkerPop
> Issue Type: Improvement
> Components: python
> Affects Versions: 3.4.6
> Reporter: Stephen Mallette
> Priority: Critical
>
> After TINKERPOP-2360 we've started down the path of coercing python numerics
> to Java type ranges. GraphBinary doesn't do that and therefore switching
> serializers from GraphSON to GraphBinary will have the potential to result in
> error if the python numeric overflows the Java integer space. In addition, we
> don't support {{BigInteger}} serialization apparently so that remains a
> problem. This ticket should just sort out GraphBinary and numbers all at once.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
