[
https://issues.apache.org/jira/browse/TINKERPOP-3282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18124713#comment-18124713
]
ASF GitHub Bot commented on TINKERPOP-3282:
-------------------------------------------
spmallette commented on code in PR #3639:
URL: https://github.com/apache/tinkerpop/pull/3639#discussion_r4211491046
##########
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/AbstractTinkerGraph.java:
##########
@@ -337,13 +322,31 @@ public void clear() {
}
/**
- * This method only has an effect if the {@link
TinkerGraph#GREMLIN_TINKERGRAPH_GRAPH_LOCATION} is set, in which case the
- * data in the graph is persisted to that location. This method may be
called multiple times and does not release
- * resources.
+ * Closes the graph, releasing any resources held by its {@link
TinkerServiceRegistry}. This method may be called
+ * multiple times and is a no-op with respect to graph data for the
in-memory implementation. Transactional
+ * implementations that are backed by a {@link
org.apache.tinkerpop.gremlin.tinkergraph.structure.storage.TinkerStorage}
+ * engine flush and close that engine here.
*/
@Override
public void close() {
- if (graphLocation != null) saveGraph();
+ if (storage != null) {
Review Comment:
created an issue for this:
https://issues.apache.org/jira/browse/TINKERPOP-3291
> TinkerGraph file persistence
> ----------------------------
>
> Key: TINKERPOP-3282
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3282
> Project: TinkerPop
> Issue Type: Improvement
> Components: tinkergraph
> Affects Versions: 3.7.6
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Major
>
> Give TinkerGraph a basic file persistence option tied to its transactional
> usage so that it can support some more complex use cases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
