[ 
https://issues.apache.org/jira/browse/TINKERPOP-3095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18128922#comment-18128922
 ] 

ASF GitHub Bot commented on TINKERPOP-3095:
-------------------------------------------

codecov-commenter commented on PR #3727:
URL: https://github.com/apache/tinkerpop/pull/3727#issuecomment-6278789343

   ## 
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/3727?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :x: Patch coverage is `72.72727%` with `3 lines` in your changes missing 
coverage. Please review.
   :white_check_mark: Project coverage is 76.32%. Comparing base 
([`a28cd1f`](https://app.codecov.io/gh/apache/tinkerpop/commit/a28cd1f2f1f10c140030a56de44c5c6c045af5f0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`0023038`](https://app.codecov.io/gh/apache/tinkerpop/commit/0023038736c15cf4f687e78e1b4b0ee742c1c6d9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 740 commits behind head on master.
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/tinkerpop/pull/3727?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[.../gremlin/driver/remote/DriverRemoteConnection.java](https://app.codecov.io/gh/apache/tinkerpop/pull/3727?src=pr&el=tree&filepath=gremlin-driver%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftinkerpop%2Fgremlin%2Fdriver%2Fremote%2FDriverRemoteConnection.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1kcml2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2RyaXZlci9yZW1vdGUvRHJpdmVyUmVtb3RlQ29ubmVjdGlvbi5qYXZh)
 | 72.72% | [3 Missing :warning: 
](https://app.codecov.io/gh/apache/tinkerpop/pull/3727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3727      +/-   ##
   ============================================
   - Coverage     76.35%   76.32%   -0.04%     
   - Complexity    13424    14350     +926     
   ============================================
     Files          1012     1005       -7     
     Lines         60341    57883    -2458     
     Branches       7075     7705     +630     
   ============================================
   - Hits          46076    44180    -1896     
   + Misses        11548    10937     -611     
   - Partials       2717     2766      +49     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by 
Harness](https://app.codecov.io/gh/apache/tinkerpop/pull/3727?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> Provide a path for selecting script engine for traversals in TP4
> ----------------------------------------------------------------
>
>                 Key: TINKERPOP-3095
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3095
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: driver
>    Affects Versions: 4.0.0
>            Reporter: Valentyn Kahamlyk
>            Priority: Critical
>
> For string queries there is now a simple way to select script engine which 
> the query will be executed
> {code:java}
> final RequestOptions ro = 
> RequestOptions.build().language("gremlin-lang").create();
> final List result = client.submit("g.inject(1)", ro).toList();{code}
> We need to do the same thing for traversal based requests, Something like
> {code:java}
> final GraphTraversalSource g = 
> traversal().with(DriverRemoteConnection.using(cluster)).with("language", 
> "gremlin-lang");
> final List result = g.inject(1).toList());{code}
> *or*
> {code:java}
> final GraphTraversalSource g = 
> traversal().with(DriverRemoteConnection.using(cluster, "g",  "gremlin-lang));
> final List result = g.inject(1).toList());{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to