[
https://issues.apache.org/jira/browse/TINKERPOP-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18136474#comment-18136474
]
ASF GitHub Bot commented on TINKERPOP-3291:
-------------------------------------------
spmallette opened a new pull request, #3758:
URL: https://github.com/apache/tinkerpop/pull/3758
https://issues.apache.org/jira/browse/TINKERPOP-3291
Move durable storage state from AbstractTinkerGraph into
TinkerStorageGraph. The TinkerStorage SPI now takes a TinkerStorageGraph.
VOTE +1
<!--
Thanks for contributing! Reminders:
+ TARGET the earliest branch where you want the change
3.7-dev -> 3.7.7 (non-breaking only)
3.8-dev -> 3.8.2 (non-breaking only)
master -> 4.0.0
+ Committers will MERGE the PR forward to newer versions
+ ADD entry to the CHANGELOG.asciidoc for the targeted version
Do not reference a JIRA number there
+ ADD JIRA number to title and link in description
+ PRs requires 3 +1s from committers OR
1 +1 and 7 day wait to merge.
+ MORE details: https://s.apache.org/rtnal
-->
> Consider refactoring to TinkerStorageGraph structure
> ----------------------------------------------------
>
> Key: TINKERPOP-3291
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3291
> Project: TinkerPop
> Issue Type: Improvement
> Components: tinkergraph
> Affects Versions: 4.0.0
> Reporter: Stephen Mallette
> Priority: Major
>
> Determine if we could push down all durable storage state logic out of
> {{AbstractTinkerGraph}} into {{TinkerStorageGraph}} since such logic really
> only applies to that implementation. The {{TinkerStorage}} interface takes
> {{AbstractTinkerGraph}} in {{open}}, {{replay}}, {{compact}} and
> {{maybeCompact}}, and {{GraphBinaryStorage.writeSnapshot}} calls
> {{graph.committedVertices()}}. Moving everything down therefore means
> retyping the interface to take {{TinkerStorageGraph}}.
>
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
