[ 
https://issues.apache.org/jira/browse/TINKERPOP3-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487147#comment-14487147
 ] 

stephen mallette commented on TINKERPOP3-613:
---------------------------------------------


I thought of a few odds/ends as i was looking at the code that you might be 
coming back to later, but here they are anyway:

* Could use some core unit tests around the {{addTo}} methods and any methods 
that enforce an expectation of operations (e.g. enforce the expectation that 
adjacent vertices don't have properties)
* {{StarGraph}} serves a fairly special purpose so:
** Some javadoc on the class would be helpful in describing that case and on 
methods that might have any different behavior from what is expected.
** It seems to have all {{Features}} enabled - to what extent can we properly 
defined features to lock down expectations of that {{Graph}} implementation?

> Create StarGraph as a micro "TinkerGraph"-style POJO graph.
> -----------------------------------------------------------
>
>                 Key: TINKERPOP3-613
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-613
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: process, structure
>            Reporter: Marko A. Rodriguez
>            Assignee: Marko A. Rodriguez
>             Fix For: 3.0.0.GA
>
>
> It is important that reduce the size of the graph in OLAP so we can hold as 
> much in memory as possible and thus, decrease compute times. In order to 
> reduce the serialization cost, we have the following ticket TINKERPOP3-609. 
> This ticket is about reducing the in-memory footprint. Right now we use 
> TinkerGraph as the "star graph" for TinkerGraphComputer, GiraphGraphComputer, 
> and SparkGraphComputer. While TinkerGraph is small, it could be smaller. 
> We should introduce {{StarGraph}} that provides the following benefits over 
> {{TinkerGraph}}
> * A {{StarEdge}} only has the adjacent vertex id.
> * All labels are enum'd by some short number-based HashMap.
> * {{StarElements}} should not maintain a reference back to Graph (i.e. 
> {{.graph()}}).
> * The graph should only have a set of vertices, not edges.
> * The above vertex set should be a bloom filter.
> * There will be no indices in {{StarGraph}}.
> * Removing one edge will automatically drop all edges (for fast MapReduce 
> prep).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to