On Wed, May 13, 2015 at 9:41 PM Matt Franklin <[email protected]> wrote:
> Apologies on the delay. $dayJob has been eating my time the last couple > of weeks. I will look at it tomorrow and provide feedback. > > > On Wed, May 13, 2015 at 3:45 PM Stephen Mallette <[email protected]> > wrote: > >> Mentors, I don't think we've received any feedback on this change I made >> to >> the source NOTICE file. As I've said before, I think I've handled it >> properly, but it would be nice to know for sure. For convenience, I'll >> repost the link to the six lines I added where I'm requesting review: >> >> >> https://github.com/apache/incubator-tinkerpop/blob/0ee87f83ac23a37c942a6160d4c3814f5ea22ee1/NOTICE#L26-L31 >> >> Could someone please take a look for us and provide feedback? >> >> Thanks, >> >> Stephen >> >> On Fri, May 8, 2015 at 2:46 PM, Stephen Mallette <[email protected]> >> wrote: >> >> > Mentors, is there any chance one of you could take a look at the update >> I >> > made to the source NOTICE file (as referenced earlier in this thread)? >> I'd >> > like to know if I've handled that change appropriately. >> > >> > Thanks, >> > >> > Stephen >> > >> > >> > On Thu, Apr 30, 2015 at 2:30 PM, Stephen Mallette <[email protected] >> > >> > wrote: >> > >> >> Mentors, I came across a couple snippets of code that we use that came >> >> from another Apache 2 licensed project. As I understand it, that means >> that >> >> we have to make reference to that in our source NOTICE. Here's the >> change >> >> that I made based on this finding: >> >> >> >> >> >> >> https://github.com/apache/incubator-tinkerpop/blob/0ee87f83ac23a37c942a6160d4c3814f5ea22ee1/NOTICE#L26-L31 >> >> >> >> Was that the right way to handle that? >> > s/taken/incorporated Other than that, it looks good. You could more clearly indicate that those two functions are what you are referring to, but that isn't a big deal. You might also consider listing it in the LICENSE file as well by reference (incorporated code from Activiti licensed under the following:) >> >> >> Thanks, >> >> >> >> Stephen >> >> >> > >> > >> >
