This is an interesting problem. Technically, the solution is to impose a feature check on all tests that @LoadDataWith like this:
!supportUserSuppliedId || supportsNumericId This mechanism doesn't exist atm unfortunately. Of course, that will greatly decrease your test coverage as many tests will be ignored given your feature set, but at least it will allow things to execute without an error condition. I'm not sure how to handle this issue well because our sample data uses numeric ids and i don't think we want to have lots of different versions of the test data just to cope with differing id systems. At the same time, I'm sure it is possible that others will have id systems like yours so.... I can think of two options immediately: 1. Make it so that your graph can work without userSuppliedIds. Have it be a configuration. Then, create one set of tests to run the suite with that configuration and a different set of tests that run the suite in the other configuration. 2. Make it so that supportsNumericId is possible. You would convert the Number to String inside your addVertex(). I think the test suite would accept that across the board, but you'd have to try it and see. Either way you go, I still intend to implement !supportUserSuppliedId || supportsNumericId. Please let me know the direction you go (or if you come up with another way). On Thu, May 21, 2015 at 4:47 PM, Ran Magen <[email protected]> wrote: > Yes, because I support UserSuppliedIds of type String. Or am I > understanding it wrong? > > On Thu, 21 May 2015 at 20:02 stephen mallette (JIRA) <[email protected]> > wrote: > > > > > [ > > > https://issues.apache.org/jira/browse/TINKERPOP3-695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > > ] > > > > stephen mallette updated TINKERPOP3-695: > > ---------------------------------------- > > Priority: Major (was: Blocker) > > Affects Version/s: (was: 3.0.0.GA) > > Assignee: stephen mallette > > > > I think i understand your problem. Had to look at your features in > > `elastic-gremlin`. You return {{true}} for > > {{Vertex.supportsUserSuppliedIds}} and {{Vertex.supportsStringIds}} and > so > > when we try to shove a numeric in via gryo load you get a type you don't > > support. Is that right? > > > > > test not calling convertId() > > > ---------------------------- > > > > > > Key: TINKERPOP3-695 > > > URL: > > https://issues.apache.org/jira/browse/TINKERPOP3-695 > > > Project: TinkerPop 3 > > > Issue Type: Improvement > > > Components: test-suite > > > Reporter: Ran Magen > > > Assignee: stephen mallette > > > > > > any test that uses Attachable to load its graph (e.g. using the Gryo > > loader) will not pass the id through the graph providers convertId(id). > > there are around 60 different tests affected. > > > The offending line: > > > > > > https://github.com/apache/incubator-tinkerpop/blob/4bbbb6365f36c20ad63ca4665657fd1169a7d246/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/Attachable.java#L276 > > > > > > > > -- > > This message was sent by Atlassian JIRA > > (v6.3.4#6332) > > >
