[ 
https://issues.apache.org/jira/browse/TINKERPOP3-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566173#comment-14566173
 ] 

Ran Magen commented on TINKERPOP3-695:
--------------------------------------

Well those tests try to assign an "unsupported" ID (for example an integer
in a graph that doesn't support numeric IDs). It then expects the graph to
throw an exception accordingly. Because I handle those cases by converting
the id to a string, the tests fail.

Following your explanation regarding the purpose of SupportsNumericId, it
seems to me like the premise of these tests might be wrong..

On שבת, 30 במאי 2015 at 16:58 stephen mallette (JIRA) <[email protected]>



> test not calling convertId()
> ----------------------------
>
>                 Key: TINKERPOP3-695
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-695
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: test-suite
>            Reporter: Ran Magen
>            Assignee: stephen mallette
>             Fix For: 3.0.0.GA
>
>
> any test that uses Attachable to load its graph (e.g. using the Gryo loader) 
> will not pass the id through the graph providers convertId(id). there are 
> around 60 different tests affected.
> The offending line:
> https://github.com/apache/incubator-tinkerpop/blob/4bbbb6365f36c20ad63ca4665657fd1169a7d246/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/Attachable.java#L276



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to