[
https://issues.apache.org/jira/browse/TINKERPOP3-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette updated TINKERPOP3-714:
----------------------------------------
Issue Type: Improvement (was: Bug)
As noted on TINKERPOP3-713 I was evaluating this issue based on Apache license
conflicts. As there aren't any such conflicts given my understanding of:
http://www.apache.org/legal/resolved.html#cc-sa
I'd say that we need to evaluate this PR on its own merit. As [~okram] has put
it to me on multiple occasions: "HadoopGremlin is a balancing act of
exclusions." I get the nature of "findbugs" and logically it seems ok to
exclude that, but unless you've done the leg work of running the full
integration test suite builds with your change -- test Giraph, Hadoop, Spark --
it's hard to know with certainty what this exclusion does.
Have you executed those test suites and performed any manual testing to be sure
that those systems are unaffected by this change?
> Exclude jsr305 jar in assemblies to prevent jsr305 cc license from appearing
> in distribution
> --------------------------------------------------------------------------------------------
>
> Key: TINKERPOP3-714
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-714
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: build-release
> Environment: all builds
> Reporter: David Robinson
> Assignee: stephen mallette
> Labels: build
> Fix For: 3.0.0.GA
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> jsr305 is licensed under the creative commons license and is packaged
> currently in the hadoop-gremlin-3.0.0-SNAPSHOT-job.jar and the standalone
> directory. It also isn't needed since it is a build time static checker.
> Change the assembly xmls to exclude the inclusion of jsr305.
> A pull request will be submitted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
