[
https://issues.apache.org/jira/browse/TINKERPOP3-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14579064#comment-14579064
]
David Robinson commented on TINKERPOP3-714:
-------------------------------------------
Hey Stephen,
Thanks for looking into this with me.
I did run the full integration test suite with the proposed changes in the
build and everything passed.
I also "grepped around" in the pom files and code a bit, and with that adhoc
approach, did not see
anything that appeared it used jsr305.
I did not run additional manual tests on each platform. While I can't
guarantee nothing gets broken,
it seems that since this is a static analysis annotation file (as you said), it
is unlikely this breaks any run time
function in TinkerPop.
Besides the license, it does get an extraneous jar out of the distribution.
On the side, I am trying to resolve the apparent differences between the legal
advice I am receiving and the link you sent, but can't comment on that at the
moment.
> Exclude jsr305 jar in assemblies to prevent jsr305 cc license from appearing
> in distribution
> --------------------------------------------------------------------------------------------
>
> Key: TINKERPOP3-714
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-714
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: build-release
> Environment: all builds
> Reporter: David Robinson
> Assignee: stephen mallette
> Labels: build
> Fix For: 3.0.0.GA
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> jsr305 is licensed under the creative commons license and is packaged
> currently in the hadoop-gremlin-3.0.0-SNAPSHOT-job.jar and the standalone
> directory. It also isn't needed since it is a build time static checker.
> Change the assembly xmls to exclude the inclusion of jsr305.
> A pull request will be submitted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
