[
https://issues.apache.org/jira/browse/TINKERPOP3-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955870#comment-14955870
]
ASF GitHub Bot commented on TINKERPOP3-850:
-------------------------------------------
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/104#issuecomment-147877774
VOTE +1.
NOTES: I don't like how many `addVertex()` methods we have now. I don't
want our core APIs to be dumping grounds for method permutations (even with
`default`) as I would prefer these APIs stay clean and minimalistic (and
ultimately, simple for the provider to implement). However, if this is
*required* by Scala, then we can add it. If its just a *nicety* for Scala we
shouldn't (I leave it up to @mhfrantz to decide). As there will always be a
"pretty please" down the line from some other language... We shouldn't cater if
the language has a workaround (e.g. how did Gremlin-Scala work prior to this
moment?).
> Reduce Graph.addVertex overload ambiguity
> -----------------------------------------
>
> Key: TINKERPOP3-850
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-850
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.0.1-incubating
> Reporter: Matt Frantz
> Assignee: Matt Frantz
> Labels: breaking
> Fix For: 3.1.0-incubating
>
>
> Create the following overloads:
> {noformat}
> Vertex addVertex();
> Vertex addVertex(String label);
> Vertex addVertex(Object key, Object value, Object...keyValues);
> {noformat}
> This would avoid the 1-arg overload, since there is only one 1-arg variant.
> It also makes the key/value structure more obvious.
> BTW, the JavaDoc now says "...the odd numbered arguments are String property
> keys," so if we actually allow other types, that doc should be fixed.
> Motivated by this dicussion:
> https://groups.google.com/d/msgid/gremlin-users/eb2a451a-af66-48a1-989c-8021473647fc%40googlegroups.com
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
