Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/107#issuecomment-148037986
Oh - so in the case i was specifying, it reads from Neo4j and writes to
TinkerGraph. Now I get it - it was something obvious.
Looking at the asserts in the test - they largely just assert counts. Is
it possible to use:
https://github.com/apache/incubator-tinkerpop/blob/master/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/io/IoTest.java#L643
to assert the entire Modern graph rather than just the counts. Note that
there's some options there to ignore the ids and stuff. If you could do that,
then that should validate the work you have in `IncrementalBulkLoader` which I
don't think has tests at all.
I also think adding a test of "The Crew" is worthwhile to assure the
meta/multi property stuff is solid.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
