[
https://issues.apache.org/jira/browse/TINKERPOP3-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965479#comment-14965479
]
ASF GitHub Bot commented on TINKERPOP3-898:
-------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/115
TINKERPOP3-898: Rename ConjuctionP and ConjuctionStep to ConnectiveP and
ConnectiveStep
https://issues.apache.org/jira/browse/TINKERPOP3-898
In logic, "conjunction" implies AND. The general term for both AND and OR
is "connective."
* Renamed all `ConjunctionXXX` to `ConnectiveXXX`.
* This is a breaking change but very internal to TinkerPop steps and given
that we are not exposing the "instruction set" paradigm yet, its best this
happens now than later.
* I ran `mvn clean install` and everything built. This does NOT effect docs
nor integration testing.
* I updated the `CHANGELOG.asciidoc`.
I VOTE +1 (binding).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-898
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #115
----
commit 45fc9f261cd0baf1e7ecf817d4dd9d8f14c1e39e
Author: Marko A. Rodriguez <[email protected]>
Date: 2015-10-20T17:55:52Z
Renamed ConjunctionXXX to ConnectiveXXX as that is more resonent with the
terminology used in logic, where conjunction assumes and and dijunction or.
----
> Rename ConjuctionP and ConjuctionStep to ConnectiveP and ConnectiveStep
> -----------------------------------------------------------------------
>
> Key: TINKERPOP3-898
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-898
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.0.2-incubating
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
> Labels: breaking
> Fix For: 3.1.0-incubating
>
>
> In CS, "conjunction" means AND and "disjunction" mean OR. We have the super
> class of {{AndStep}} and {{OrStep}} as {{ConjunctionStep}}. We should rename
> this to {{ConnectiveStep}} to be consistent with the lexicon.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
