[
https://issues.apache.org/jira/browse/TINKERPOP3-905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14967509#comment-14967509
]
ASF GitHub Bot commented on TINKERPOP3-905:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/117
TINKERPOP3-905 Harden time oriented tests in ResultQueueTest
https://issues.apache.org/jira/browse/TINKERPOP3-905
Now that the test relies on a CountDownLatch to explicitly block until a
specified number of items are in the queue, the test should not randomly fail
if items are slow to get to that queue.
If you've seen this test fail before please run the standard `mvn clean
install` test suite.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-905
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #117
----
commit 18e5ccad6e8153623da41ff6ecde79aa285caf34
Author: Stephen Mallette <[email protected]>
Date: 2015-10-21T17:22:40Z
TINKERPOP3-905 Refactored ResultQueueTest to not rely on Thread.sleep().
Now that the test relies on a CountDownLatch to explicitly block until a
specified number of items are in the queue, the test should not randomly fail
if items are slow to get to that queue.
----
> Harden time oriented tests in ResultQueueTest
> ---------------------------------------------
>
> Key: TINKERPOP3-905
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-905
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: driver
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.0-incubating
>
>
> The {{ResultQueueTest}} seems to fail from time to time on different
> environments. They tend to fail because the test is bound to time and if one
> environment is slower than another for some reason we get false failures
> running the test suite.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
