[ 
https://issues.apache.org/jira/browse/TINKERPOP3-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977669#comment-14977669
 ] 

ASF GitHub Bot commented on TINKERPOP3-926:
-------------------------------------------

Github user pluradj commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/123#issuecomment-151714709
  
    +1 Ran `mvn clean install` successfully. Appreciate the trailing whitespace 
cleanup too. Looks good to me.


> Renamed TinkerGraph public statics to common pattern used for other statics.
> ----------------------------------------------------------------------------
>
>                 Key: TINKERPOP3-926
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-926
>             Project: TinkerPop 3
>          Issue Type: Bug
>          Components: tinkergraph
>    Affects Versions: 3.0.2-incubating
>            Reporter: Marko A. Rodriguez
>            Assignee: Marko A. Rodriguez
>             Fix For: 3.1.0-incubating
>
>
> These are bad. [~spmallette] Verify this isn't backwards compatible and I 
> will fix it.
> {code}
>     public static final String CONFIG_VERTEX_ID = 
> "gremlin.tinkergraph.vertexIdManager";
>     public static final String CONFIG_EDGE_ID = 
> "gremlin.tinkergraph.edgeIdManager";
>     public static final String CONFIG_VERTEX_PROPERTY_ID = 
> "gremlin.tinkergraph.vertexPropertyIdManager";
>     public static final String CONFIG_DEFAULT_VERTEX_PROPERTY_CARDINALITY = 
> "gremlin.tinkergraph.defaultVertexPropertyCardinality";
>     public static final String CONFIG_GRAPH_LOCATION = 
> "gremlin.tinkergraph.graphLocation";
>     public static final String CONFIG_GRAPH_FORMAT = 
> "gremlin.tinkergraph.graphFormat";
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to