[ 
https://issues.apache.org/jira/browse/TINKERPOP3-936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983739#comment-14983739
 ] 

stephen mallette commented on TINKERPOP3-936:
---------------------------------------------

The problem with a cache is that graph features aren't static.  They can be 
dynamic depending on the graph implementation and the configs supplied to it.  
As it can be dynamic you must have an instance created for the feature checks 
to work right.  Maybe there could be some kind of record made of skipped 
tests???? write to file??? then we consult that file on future runs to ignore 
those tests automatically?? could be dangerous to do that though, but it sounds 
feasible maybe.....not sure if you'd need a revised  custom test runner to make 
this work.

> Check feature requirements before opening graph during tests
> ------------------------------------------------------------
>
>                 Key: TINKERPOP3-936
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-936
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: test-suite
>    Affects Versions: 3.0.2-incubating
>            Reporter: Jonathan Ellithorpe
>            Assignee: stephen mallette
>            Priority: Minor
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> In AbstractGremlinTest, setup() opens a graph before checking whether or not 
> the graph meets the feature requirements to run the current test. In the case 
> that the graph does not meet the requirements, then opening the graph was 
> wasted work, since the test will not run. For some graph database 
> implementations this wasted work may be trivial, but for others it may be 
> significant (for example, if the graph object must establish connections to 
> remote servers). This wasted work adds up for each test that is skipped.
> If there is a way to check the features of a given graph implementation 
> without instantiating a new graph instance, then the order of graph 
> instantiation and feature requirement checking could be reversed, and 
> significantly reduce the time it takes to run a suite of unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to