GitHub user dkuppitz opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/131
TINKERPOP3-909: Improve steps that handle numeric data
[TINKERPOP3-909: Improve steps that handle numeric
data](https://issues.apache.org/jira/browse/TINKERPOP3-909)
Integrated `NumberHelper` in `SumStep`, `MinStep`, `MaxStep` and `MeanStep`
(`local` and `global` step variants). Had to change a few test methods where we
now get different (but more appropriate) result types.
All tests passed for me.
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-909
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/131.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #131
----
commit d49deafb0d0c157bb59c26d6148993a8cccd64fb
Author: Daniel Kuppitz <[email protected]>
Date: 2015-10-31T11:07:50Z
integrated NumberHelper in SumGlobalStep and SumLocalStep
commit eda16b504fda57f58d8d90a60421bde386528bba
Author: Daniel Kuppitz <[email protected]>
Date: 2015-10-31T17:42:09Z
modified method/type signature of SumGlobalStep after getting some feedback
from @okram
commit eba7114341b1257106db2111ed8b90b2012c0860
Author: Daniel Kuppitz <[email protected]>
Date: 2015-11-01T11:55:26Z
Integrated NumberHelper in Min-, Max- and MeanStep
commit ccc3bfc31cdf84f7a25dc1f6da89b9dc42f5490a
Author: Daniel Kuppitz <[email protected]>
Date: 2015-11-01T21:13:17Z
updated CHANGELOG and upgrade docs
commit e29a9362beb2cb2784a547b7f9e1e5d589c83d47
Author: Daniel Kuppitz <[email protected]>
Date: 2015-11-01T21:15:04Z
Merge branch 'master' into TINKERPOP3-909
Resolved Conflicts:
CHANGELOG.asciidoc
docs/src/upgrade-release-3.1.x-incubating.asciidoc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
