[
https://issues.apache.org/jira/browse/TINKERPOP3-909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14985335#comment-14985335
]
ASF GitHub Bot commented on TINKERPOP3-909:
-------------------------------------------
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/131#issuecomment-153042481
I review the code. Solid. Can't believe you go `MeanGlobalStep` to work
too. I also `mvn clean install`'d the branch and all passes.
SIDENOTE: Daniel, the quantum Gremlin stuff is proving some practical
results where I think wave dynamics + your `NumberHelper` work, we will be able
to do exclusive or, and, disjoint union, etc. without using memory structures!
3.2.0 is going to get nasty.
VOTE +1.
> Improve steps that handle numeric data
> --------------------------------------
>
> Key: TINKERPOP3-909
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-909
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.1.0-incubating
> Reporter: Daniel Kuppitz
> Assignee: Daniel Kuppitz
> Fix For: 3.1.0-incubating
>
>
> Use the new {{NumberHelper}} (implemented in
> https://issues.apache.org/jira/browse/TINKERPOP3-861) in steps that are
> supposed to handle numeric data (e.g. {{Sum(Global)Step}},
> {{Min(Global)Step)}}, {{Max(Global)Step}}, etc.). These steps currently
> simply convert everything into a {{Double}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)