[
https://issues.apache.org/jira/browse/TINKERPOP3-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987625#comment-14987625
]
ASF GitHub Bot commented on TINKERPOP3-768:
-------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/134
TINKERPOP3-768: MatchStep in OLAP should be smart about current vertex.
https://issues.apache.org/jira/browse/TINKERPOP3-768
The previous implementation of MatchStep was not biased to patterns that
start at the current vertex. In OLTP, this is good. In OLAP, this is really
really really bad as you are incuring a massive overhead with inter process
communication. Thus, optimization, in OLAP, will sort the patterns first by
whether the traverser needs to leave the current object location and then by
TraversalType and then by multiplicity of the pattern. In the process, I
cleaned up a few things here and there in MatchStep.
Ran `mvn clean install` and all is good.
VOTE +1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-768
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #134
----
commit 956d7977f4507db8d51b0468604f3b214e0681b3
Author: Marko A. Rodriguez <[email protected]>
Date: 2015-11-03T16:16:39Z
MatchStep is smart to bias patterns towards the local star graph to reduce
inter-machine communication.
commit f644fb42b9f5e0f9216deb3f5e3088293e3ca13a
Author: Marko A. Rodriguez <[email protected]>
Date: 2015-11-03T17:05:25Z
clean up tweaks to MatchStep optimization.
----
> MatchStep in OLAP should be smart about current vertex.
> --------------------------------------------------------
>
> Key: TINKERPOP3-768
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-768
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.0.2-incubating
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
>
> Right now, {{CountMatchAlgorithm}} doesn't care which vertex the traverser is
> at when selecting a match-pattern. Given the communication overhead in OLAP,
> its best to bias pattern selection to those that are currently where the
> traverser is located.
> I think {{MatchAlgorithm}} might do well with a
> {{MatchAlgorithm.initialize(traversals,engine)}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
