[ 
https://issues.apache.org/jira/browse/TINKERPOP3-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14991976#comment-14991976
 ] 

ASF GitHub Bot commented on TINKERPOP3-914:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/137

    TINKERPOP3-914 Gremlin Console :remote to Gremlin Server supports alias

    https://issues.apache.org/jira/browse/TINKERPOP3-914
    
    Added a "alias" option to :remote config that lets the user supply 
key/value pairs representing the aliases.  Included "show" and "reset" options 
as well.  Updated docs which generate nicely. 
    
    Unit tests were added as well as integration tests so build/test should be:
    
    ```text
    mvn clean install
    mvn clean install -DskipIntegrationTests=false -pl gremlin-console
    ```
    
    Test manually after starting gremlin server with:
    
    ```text
    gremlin> :remote connect tinkerpop.server conf/remote.yaml
    ==>Connected - localhost/127.0.0.1:8182
    gremlin> :> TinkerFactory.generateModern(graph)
    ==>null
    gremlin> :> graph
    ==>tinkergraph[vertices:6 edges:6]
    gremlin> :> g.V()
    ==>v[1]
    ==>v[2]
    ==>v[3]
    ==>v[4]
    ==>v[5]
    ==>v[6]
    gremlin> :remote config alias x g
    ==>x=g
    gremlin> :> x.V()
    ==>v[1]
    ==>v[2]
    ==>v[3]
    ==>v[4]
    ==>v[5]
    ==>v[6]
    gremlin> :remote config alias show
    ==>x=g
    gremlin> :remote config alias reset
    ==>Aliases cleared
    gremlin> :remote config alias show
    gremlin> 
    ```
    
    VOTE: +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-914

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/137.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #137
    
----
commit 2c7823e8abc9dc3214c33296b58182a9bf961882
Author: Stephen Mallette <[email protected]>
Date:   2015-11-05T16:52:55Z

    TINKERPOP3-914 Gremlin Console :remote to Gremlin Server supports alias
    
    Added a "alias" option to :remote config that lets the user supply 
key/value pairs representing the aliases.  Included "show" and "reset" options 
as well.  Updated docs which generate nicely.

----


> DriverRemoteAcceptor in Gremlin Console supports aliases
> --------------------------------------------------------
>
>                 Key: TINKERPOP3-914
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-914
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: console
>    Affects Versions: 3.0.2-incubating
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>             Fix For: 3.1.0-incubating
>
>
> Not sure how this should work, but it seems that "aliases" are growing in 
> importance and perhaps even a pattern for usage.  As such, the Console and 
> it's {{:submit}} should respect it somehow.  Maybe a remote should get bound 
> to a single rebinding?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to