GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/140
TINKERPOP3-885 Revision of #113
this is a revision of the work done here: #113 - the other had two +1s
already but I thought that given the added changes it should be reviewed yet
again. this commit - a806c7ec0a4fc5baaa1d684a647d0e5084f9c4cb - has the
description of the changes since #113
you can test with:
```text
mvn clean install -DincludeNeo4j
```
Note that I tested against Titan as well to validate the changes so that
should give us added confidence that this change will work for everyone.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-885
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/140.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #140
----
commit 8ea6aa25e8fb88f64c8b43572eb4e518233db4b1
Author: Dylan Millikin <[email protected]>
Date: 2015-10-20T12:29:44Z
Made Transaction.onReadWrite() a ThreadLocal setting
commit 5b0dd760a7d1c8609ffda2a415c18d541b2e51ff
Author: Dylan Millikin <[email protected]>
Date: 2015-10-21T12:31:16Z
Merge branch 'master' into TINKERPOP-886
commit 285bd28b523da9eacb8e84f270a0ebf906f6ca91
Author: Dylan Millikin <[email protected]>
Date: 2015-10-21T12:34:43Z
removed typos
commit 35e97f08e4359c0ae09f431c7680f8c13567549b
Author: Dylan Millikin <[email protected]>
Date: 2015-10-21T12:37:19Z
moved Driver implementor section down in it's correct position
commit 9881e6ecb651b3300dea1ad887d22ce1f4763b51
Author: Stephen Mallette <[email protected]>
Date: 2015-10-21T13:03:35Z
Merge remote-tracking branch 'origin/master' into TINKERPOP3-885
commit 3938caed7fd0eb62453a2a2deb716e283c4b79a7
Author: Dylan Millikin <[email protected]>
Date: 2015-10-25T12:45:35Z
moved logic to AbstractThreadLocalTransaction and added a couple of tests
commit 46f821a846abc4fceb776f11c3b25888f01d60ef
Author: Dylan Millikin <[email protected]>
Date: 2015-10-25T12:45:35Z
moved logic to AbstractThreadLocalTransaction and added a couple of tests
commit 956d34de836693ea0bdd552ce434493ed7d1b14c
Author: Dylan Millikin <[email protected]>
Date: 2015-11-06T19:40:23Z
Merge branch 'TP-885' of https://github.com/PommeVerte/incubator-tinkerpop
into TP-885
Conflicts:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/TransactionTest.java
commit 7ce6784466e8714edac465f2bbfee6dda5c019dd
Author: Dylan Millikin <[email protected]>
Date: 2015-11-06T21:40:57Z
Merge remote-tracking branch 'tinkerpop/master' into TP-885
Conflicts:
docs/src/upgrade-release-3.1.x-incubating.asciidoc
commit 789d6f70c7a76f2e6fb935d3dc1a659b8c0c871b
Author: Dylan Millikin <[email protected]>
Date: 2015-11-06T21:45:40Z
Merge pull request #1 from PommeVerte/TP-885
moved logic to AbstractThreadLocalTransaction and added a couple of tests
commit 1aa1b5ac739a35ab1872ee5602a55c33cf035f29
Author: Stephen Mallette <[email protected]>
Date: 2015-11-06T23:55:42Z
Merge branch 'TINKERPOP-885' of
https://github.com/PommeVerte/incubator-tinkerpop into TINKERPOP3-885
commit a806c7ec0a4fc5baaa1d684a647d0e5084f9c4cb
Author: Stephen Mallette <[email protected]>
Date: 2015-11-07T14:08:12Z
TINKERPOP3-885 Adjustments to work from @PommeVerte from his PR at #113
Removed two tests that didn't really test threaded transactions properly.
Removed the static modifier on close/readWrite member variables which would
cause a problem if the same thread was working with multiple graph instances.
Removed setReadWrite and setClose from AbstractTransaction as they were
redundnant to just onReadWrite and onClose (they offered no functionality in
and of themselves). Altered the nature of AbstractThreadedTransaction a bit as
threaded transactions are really "manual" by virtue of their creation. The
transaction is opened when you createThreadedTransaction() and really shouldn't
be re-used after close. An new one should be created. We don't have those
semantics enforced now, but that's typically how this feature has been used in
the past.
commit 7ecd3538eaa2ab3581200e74f71ee1e1e45a4ea7
Author: Stephen Mallette <[email protected]>
Date: 2015-11-07T14:29:07Z
Updates to upgrade docs.
commit 02623c7f59df26f18c4bb4acb859b55894b5ab3f
Author: Stephen Mallette <[email protected]>
Date: 2015-11-07T14:30:09Z
Update changelog.
commit 6b532f78900f631b9d71d37c1b8293ec8adab71d
Author: Stephen Mallette <[email protected]>
Date: 2015-11-07T14:32:34Z
Update reference docs to denote the ThreadLocal nature of the transaction
settings.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
