Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/141#issuecomment-155047685
Thanks for working on this. I see you did something for reading a graph,
but what about writing?
https://github.com/kushal256/incubator-tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerGraph.java#L296
Note that the docs needed to be updated:
https://github.com/apache/incubator-tinkerpop/blob/master/docs/src/implementations.asciidoc#configuration
Specifically, the configuration description for
`gremlin.tinkergraph.graphFormat` needs something to denote this new feature.
Would be nice to see a test case as well. Perhaps you could stub a
reader/writer and assert that the class gets created and the appropriate
methods are called. wdyt?
I'm not sure how others feel, but I think we will wait to merge this until
after release of 3.1.0-incubating (in code freeze for that now).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
