[ 
https://issues.apache.org/jira/browse/TINKERPOP3-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999620#comment-14999620
 ] 

ASF GitHub Bot commented on TINKERPOP3-953:
-------------------------------------------

GitHub user n-tran opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/142

    TINKERPOP3-953 Artifact equality is not evaluating properly

    https://issues.apache.org/jira/browse/TINKERPOP3-953
    
    Corrected bug in artifact.equal where a local variable was overriding a 
member variable with the same name.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/n-tran/incubator-tinkerpop TINKERPOP3-953

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/142.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #142
    
----
commit 00583ecfd2eba9e8003d9b6dae47df0442000e47
Author: Nghia Tran <[email protected]>
Date:   2015-11-10T01:01:29Z

    Added unit test to Artifact
    
    Corrected bug in artifact.equal where a local variable was overriding a 
member variable with the same name.

----


> Artifact equality is not evaluating properly
> --------------------------------------------
>
>                 Key: TINKERPOP3-953
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-953
>             Project: TinkerPop 3
>          Issue Type: Bug
>          Components: groovy
>    Affects Versions: 3.0.2-incubating
>            Reporter: Nghia Tran
>            Priority: Minor
>
> The following test fails. Submitting a PR shortly.
> {code}    
> @Test
>     public void shouldBeEqual() {
>         final Artifact a = new 
> Artifact("org.apache.tinkerpop","tinkergraph-gremlin","3.0.0");
>         final Artifact b = new 
> Artifact("org.apache.tinkerpop","tinkergraph-gremlin","3.0.0");
>         assertThat(a.equals(b), is(true));
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to