Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/146#issuecomment-157733926
Thanks for noticing this and offering a fix. Somehow I missed closing that
executor.
Looking at your PR, you do a `executor().shutdownNow()` in
`Cluster.close()`. That still leaves a problem for those doing
`Cluster.closeAsync()` as that executor will continue to hang around. Maybe
your change should somehow be down here:
https://github.com/apache/incubator-tinkerpop/blob/0feaa8b47de2797e177310cd1ea3bf38d7230420/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java#L607
maybe you tack something on to the `closeIt` future to shutdown the
executor after if finishes all its jobs? or maybe we don't use the executor for
shutdown of the channel so that we separate that task from any other running
activities? do you have any thoughts on how best to do this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
