Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/141#issuecomment-158584247
@kushal256 not a problem - i figured your IDE was the culprit. if you'd
like to amend your PR with the fix to the imports that will be fine.
The other thing we tend to do is mark all variables `final` (unless they
are not - which really makes them jump out at you and makes you wonder why they
are not when you see them in the code base). so for example you added:
```text
public static Io.Builder createIoBuilder(String graphFormat) throws
ClassNotFoundException, IllegalAccessException, InstantiationException {
Class<Io.Builder> ioBuilderClass = (Class<Io.Builder>)
Class.forName(graphFormat);
Io.Builder ioBuilder = ioBuilderClass.newInstance();
return ioBuilder;
}
```
`graphFormat`, `ioBuilder` and `ioBuilderClass` should be `final`.
`IoCore` is also a "public" API class, so some javadoc on that method would be
good.
And last but not least, if you want to really tie a bow on this, you would
add an entry to the CHANGELOG for 3.1.1:
https://github.com/apache/incubator-tinkerpop/blob/master/CHANGELOG.asciidoc#tinkerpop-311-not-officially-released-yet
Please comment when you've updated the PR with those little changes and
i'll merge after that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
