[
https://issues.apache.org/jira/browse/TINKERPOP3-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020674#comment-15020674
]
Jonathan Ellithorpe commented on TINKERPOP3-985:
------------------------------------------------
Yup, just submitted a pull request.
In the commit I included some additional notes about the feature requirements
checking for this method (primarily, that the check for ADD_PROPERTY support on
vertices is implicit, because the SIMPLE feature set doesn't check for that
directly, but rather for being able to add meta properties).
Also, I just saw in the SIMPLE feature set that a check is made for
Graph.Features.VertexPropertyFeatures.FEATURE_STRING_VALUES. Is this if
statement check in the unit test code itself even needed then in the first
place? If not, perhaps the right thing to do is to delete it all together (in
which case you'll want to disregard my PR which simply fixes the if statement
check).
Jonathan
> shouldPersistDataOnClose makes incorrect feature check
> ------------------------------------------------------
>
> Key: TINKERPOP3-985
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-985
> Project: TinkerPop 3
> Issue Type: Bug
> Components: test-suite
> Affects Versions: 3.0.2-incubating
> Reporter: Jonathan Ellithorpe
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.1-incubating
>
>
> Lines 1206-1211 in GraphTest.java (gremlin-test):
> final Vertex v = graph.addVertex();
> final Vertex u = graph.addVertex();
> if (graph.features().edge().properties().supportsStringValues()) {
> v.property(VertexProperty.Cardinality.single, "name", "marko");
> u.property(VertexProperty.Cardinality.single, "name", "pavel");
> }
> The check tests for string value properties on edges, but it should be
> checking string values on properties of vertices.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
