Hi Jonathan, thanks for bringing this up. It would be nice if we could expand coverage of our test suite by simply improving the way in which features are applied. I was about to suggest a big set of changes when I realized that FeatureRequirementSet.SIMPLE is just defined wrong. It shouldn't have
addFeatureRequirement.Factory.create(Graph.Features.VertexPropertyFeatures.FEATURE_ADD_PROPERTY, Graph.Features.VertexPropertyFeatures.class)); it should just be: On Mon, Nov 23, 2015 at 7:39 PM, Jonathan Ellithorpe <j...@cs.stanford.edu> wrote: > Hello all, > > I am currently working on an experimental implementation of TinkerPop3 on > an in-memory key-value store called RAMCloud. In the process of running the > unit tests I noticed that turning on support for persistence did not > trigger any new unit tests in GraphTests. Looking into the matter, I found > that the unit test that tests this, shouldPersistOnClose, was not executing > because meta properties support is included in its feature requirements, > but I do not have support for meta properties. Oddly, though, this features > requirement seems to be superfluous, since the test does not utilize meta > properties. > > An orthogonal issue seems to be that > Graph.Features.VertexPropertyFeatures.FEATURE_ADD_PROPERTY <==> > Graph.Features.VertexFeatures.FEATURE_META_PROPERTIES > > Best, > Jonathan >
