GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/158
TINKERPOP3-912 Improve the ability to embed Gremlin Server with Channelizer
injection
https://issues.apache.org/jira/browse/TINKERPOP3-912
I folded in a couple of changes related to general refactoring that were
above and beyond the scope described in the JIRA ticket. Most notably was the
removal of more code related the deprecated "rebinding" term.
I thought this ticket was going to be much bigger when i started, but it
seemed to be less so for 3.1.1 anyway. Anyway, it is pretty deep in the guts of
Gremlin Server, so reviewers should focus mostly on ensuring that there are no
regressions as a result of this refactoring work.
I tested with:
```text
mvn clean install
mvn verify -DskipIntegrationTests=false -pl gremlin-server
```
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-912
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/158.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #158
----
commit 5cb591196c8c4b34d6f7d85c736f2c9e985f8287
Author: Stephen Mallette <[email protected]>
Date: 2015-11-26T14:44:06Z
Refactored the StandardOpProcessor to be more flexibile for extenders.
Made it so that extending classes don't need to override evalOp and made it
so that they can re-use the binding maker as needed.
commit 12e1250a55df841fbcd8aa37d1da998a17cd7fff
Author: Stephen Mallette <[email protected]>
Date: 2015-11-26T16:04:48Z
Get rid of more internal "rebound" naming.
The naming of "rebound" was deprecated for 3.1.0 so this deprecation was
due. Not a breaking changes as the new Alias client extends ReboundClient -
should work as a compile timer replacement.
commit fe0e6654a098419ade421bf686db52a74fd2a72b
Author: Stephen Mallette <[email protected]>
Date: 2015-11-26T16:17:59Z
Correct grammar in exception message.
commit b007e8333092fff4ab436a8d5b81d9e0fdc32357
Author: Stephen Mallette <[email protected]>
Date: 2015-11-27T13:37:15Z
Minor javadoc fix.
commit d4cd1dd2868190b539a74741d17c59e6a0a0ada3
Author: Stephen Mallette <[email protected]>
Date: 2015-11-27T14:58:24Z
GremlinServerExecutor includes "hostOptions"
Added some deprecation to a GremlinServer constructor - opens a bad usage
of GremlinServerExecutor. Added a way to get the internally constructed
GremlinServerExecutor from GremlinServer. Included a hostOptions Map in
GremlinServerExecutor that will make it possible for embedding applications to
include objects that can be used by the Channelizer.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
