[
https://issues.apache.org/jira/browse/TINKERPOP3-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030213#comment-15030213
]
ASF GitHub Bot commented on TINKERPOP3-1000:
--------------------------------------------
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/159#discussion_r46068829
--- Diff:
gremlin-groovy-test/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GremlinGroovyScriptEngineOverGraphTest.java
---
@@ -36,21 +36,10 @@
import javax.script.CompiledScript;
import javax.script.ScriptEngine;
import javax.script.ScriptException;
-import javax.script.SimpleBindings;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Random;
--- End diff --
as a matter of style, can you please amend your PR to not use wildcards?
> GremlinGroovyScriptEngineOverGraphTest failures
> -----------------------------------------------
>
> Key: TINKERPOP3-1000
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-1000
> Project: TinkerPop 3
> Issue Type: Bug
> Components: test-suite
> Affects Versions: 3.1.0-incubating
> Reporter: pieter martin
>
> I am running these tests for the first time and are encountering some issues.
> The first is pretty trivial, many places in test the vertex id is not wrapped
> in single quotes resulting in,
> {noformat}
> javax.script.ScriptException:
> org.codehaus.groovy.control.MultipleCompilationErrorsException: startup
> failed:
> Script4.groovy: 1: illegal colon after argument expression;
> solution: a complex label expression before a colon must be parenthesized
> @ line 1, column 26.
> isVadas(g.V(PUBLIC.person:::1).next())
> {noformat}
> The second issue is in the multi threaded tests. The implicit transactions
> are never commit nor rolled backed. The tests create 500
> threads/transactions. My connection pool default to 100 connections and are
> thus starved hanging the test as the resources are not released.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
