[
https://issues.apache.org/jira/browse/TINKERPOP3-981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030312#comment-15030312
]
ASF GitHub Bot commented on TINKERPOP3-981:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/160
TINKERPOP3-981 - Deprecate credentialsDbLocation setting for gremlin server
simple auth.
https://issues.apache.org/jira/browse/TINKERPOP3-981
Fixed up docs and altered packaged config files. This is a non-breaking
change as the setting is still supported. It offers a warning when it is used.
Kept tests in place and added new ones to test both features.
```text
mvn clean install
mvn verify -DskipIntegrationTests=false -pl gremlin-server
```
Did the above tests and some manual testing of REST as well as the driver
in the console.
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-981
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #160
----
commit 0f4ad252c4097b888ba0df33333d11c512d3af32
Author: Stephen Mallette <[email protected]>
Date: 2015-11-27T23:25:13Z
Deprecate credentialsDbLocation setting for gremlin server simple auth.
Fixed up docs and altered packaged config files. This is a non-breaking
change as the setting is still supported. It offers a warning when it is used.
Kept tests in place and added new ones to test both features.
----
> Deprecate support for credentialsDbLocation in Gremlin Server Config
> --------------------------------------------------------------------
>
> Key: TINKERPOP3-981
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-981
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.1-incubating
>
>
> The {{credentialsDbLocation}} was created to deal with the fact that
> TinkerGraph did not support persistence. Now that we have
> {{gremlin.tinkergraph.graphLocation}} in the standard TinkerGraph config we
> can deprecate that old config option and simply rely on the configuration
> supplied to TinkerGraph itself.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
