[
https://issues.apache.org/jira/browse/TINKERPOP3-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15030997#comment-15030997
]
ASF GitHub Bot commented on TINKERPOP3-990:
-------------------------------------------
Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/156#issuecomment-160421522
VOTE +1.
This is consistent with `weight` being used as `Double` in `MODERN`.
```
gremlin> g.E().values('weight').limit(1).map{it.get().getClass()}
==>class java.lang.Double
```
> Mixed types in VertexPropertyTest
> ---------------------------------
>
> Key: TINKERPOP3-990
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-990
> Project: TinkerPop 3
> Issue Type: Bug
> Components: test-suite
> Affects Versions: 3.0.2-incubating
> Reporter: Matthias Broecheler
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.1-incubating
>
>
> {{shouldRemoveMultiPropertiesWhenVerticesAreRemoved}} of
> {{VertexPropertyTest.VertexPropertyRemoval}} mixes types. The test uses
> String data types for "name" but then also adds integers. In systems with a
> strict typesystem, those integers would get converted to Strings which makes
> the subsequent removal test fail which checks for integer.class.
> Such mixing of types should be avoided in TinkerPop tests.
> This can furthermore be found in the following test cases:
> - AddEdgeTest#g_VX1X_asXaX_outXcreatedX_addOutEXcreatedBy_a_weight_2X (mixed
> double with integer for "weight")
> -
> AddEdgeTest#g_VX1X_asXaX_outXcreatedX_addEXcreatedByX_toXaX_propertyXweight_2X
> (mixed double with integer for "weight")
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
