[
https://issues.apache.org/jira/browse/TINKERPOP3-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15036420#comment-15036420
]
ASF GitHub Bot commented on TINKERPOP3-1006:
--------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/167
TINKERPOP3-1006 Random error during builds:
shouldReloadClassLoaderWhileDoingEvalInSeparateThread()ATINKERPOP3-1006 Random
error during builds: shouldReloadClassLoaderWhileDoingEvalInSeparateThread()
Adjust tests to be a bit more bulletproof with respect to thread timing.
Not sure if i've fixed anything with this change as these tests have never
failed for me on my system. I would have CTR'd this but I'd like to see if
there is any validation that this is working correctly now. I guess runs in
Travis and those who have macs would be the best judge of whether or not this
issue is resolved.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-1006
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/167.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #167
----
commit 87201658f2023c725d4620b4a700b949605099a7
Author: Stephen Mallette <[email protected]>
Date: 2015-12-02T19:20:30Z
Adjust tests to be a bit more bulletproof with respect to thread timing.
Not sure if i've fixed anything with this change as these tests have never
failed for me on my system.
----
> Random error during builds:
> shouldReloadClassLoaderWhileDoingEvalInSeparateThread()
> -----------------------------------------------------------------------------------
>
> Key: TINKERPOP3-1006
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-1006
> Project: TinkerPop 3
> Issue Type: Bug
> Components: groovy
> Affects Versions: 3.1.0-incubating
> Reporter: Dylan Millikin
> Assignee: stephen mallette
> Fix For: 3.1.1-incubating
>
>
> The following error creeps in randomly during the travis builds. Note that
> I've had this issue on macOsX as well. Looks like it could potentially be an
> issue with an assert running before a thread finishes (or something along
> those lines).
> {code}
> shouldReloadClassLoaderWhileDoingEvalInSeparateThread(org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngineTest)
> Time elapsed: 1.046 sec <<< FAILURE!
> java.lang.AssertionError: null
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertFalse(Assert.java:64)
> at org.junit.Assert.assertFalse(Assert.java:74)
> at
> org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngineTest.shouldReloadClassLoaderWhileDoingEvalInSeparateThread(GremlinGroovyScriptEngineTest.java:251)
> Running
> org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngineCompileStaticTest
> Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.223 sec -
> in
> org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngineCompileStaticTest
> Running org.apache.tinkerpop.gremlin.util.function.ScriptEngineLambdaTest
> Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.116 sec -
> in org.apache.tinkerpop.gremlin.util.function.ScriptEngineLambdaTest
> Results :
> Failed tests:
>
> GremlinGroovyScriptEngineTest.shouldReloadClassLoaderWhileDoingEvalInSeparateThread:251
> null
> Tests in error:
> GremlinExecutorTest.shouldContinueToEvalScriptsEvenWithTimedInterrupt:505 ยป
> Execution
> Tests run: 81, Failures: 1, Errors: 1, Skipped: 3
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache TinkerPop ................................... SUCCESS [ 10.622
> s]
> [INFO] Apache TinkerPop :: Gremlin Shaded ................. SUCCESS [ 6.860
> s]
> [INFO] Apache TinkerPop :: Gremlin Core ................... SUCCESS [01:07
> min]
> [INFO] Apache TinkerPop :: Gremlin Test ................... SUCCESS [ 19.785
> s]
> [INFO] Apache TinkerPop :: Gremlin Groovy ................. FAILURE [01:01
> min]
> [INFO] Apache TinkerPop :: Gremlin Groovy Test ............ SKIPPED
> [INFO] Apache TinkerPop :: TinkerGraph Gremlin ............ SKIPPED
> [INFO] Apache TinkerPop :: Hadoop Gremlin ................. SKIPPED
> [INFO] Apache TinkerPop :: Spark Gremlin .................. SKIPPED
> [INFO] Apache TinkerPop :: Giraph Gremlin ................. SKIPPED
> [INFO] Apache TinkerPop :: Neo4j Gremlin .................. SKIPPED
> [INFO] Apache TinkerPop :: Gremlin Driver ................. SKIPPED
> [INFO] Apache TinkerPop :: Gremlin Server ................. SKIPPED
> [INFO] Apache TinkerPop :: Gremlin Console ................ SKIPPED
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 02:46 min
> [INFO] Finished at: 2015-11-25T21:18:34+00:00
> [INFO] Final Memory: 46M/415M
> [INFO]
> ------------------------------------------------------------------------
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on
> project gremlin-groovy: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /home/travis/build/apache/incubator-tinkerpop/gremlin-groovy/target/surefire-reports
> for the individual test results.
> [ERROR] -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the
> command
> [ERROR] mvn <goals> -rf :gremlin-groovy
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
