Github user laxatives commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/175#issuecomment-164090219
Yes, this failed for both GraphSON and Gryo (but NOT GraphML) in master:
```Tests run: 796, Failures: 2, Errors: 0, Skipped: 214, Time elapsed:
8.361 sec <<< FAILURE! - in
org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraphStructureStandardTest
shouldReadWriteSelfLoopingEdges(org.apache.tinkerpop.gremlin.structure.io.IoTest$GraphSONTest)
Time elapsed: 0.01 sec <<< FAILURE!
java.lang.AssertionError: expected:<2> but was:<1>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at
org.apache.tinkerpop.gremlin.structure.io.IoTest$GraphSONTest.shouldReadWriteSelfLoopingEdges(IoTest.java:457)
shouldReadWriteSelfLoopingEdges(org.apache.tinkerpop.gremlin.structure.io.IoTest$GryoTest)
Time elapsed: 0.005 sec <<< FAILURE!
java.lang.AssertionError: expected:<2> but was:<1>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at
org.apache.tinkerpop.gremlin.structure.io.IoTest$GryoTest.shouldReadWriteSelfLoopingEdges(IoTest.java:308)
```
If GraphSONReader assumes that for every edge E,
E.outV().edges().contains(E), it seems reasonable that that assumption could
have propagated to other places. Maybe its better to include self edges in both
edges(OUT) and edges(IN)? This would also ensure that every graph G has
G.V().edgesOut().count() + G.V().edgesIn().count() == 2 * G.edges().count(),
which is clearly not the case now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
