[
https://issues.apache.org/jira/browse/TINKERPOP-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056509#comment-15056509
]
ASF GitHub Bot commented on TINKERPOP-954:
------------------------------------------
Github user twilmes commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/178#issuecomment-164530910
Yep, tests are good here.
VOTE: +1
> Consistent test directory usage
> -------------------------------
>
> Key: TINKERPOP-954
> URL: https://issues.apache.org/jira/browse/TINKERPOP-954
> Project: TinkerPop
> Issue Type: Improvement
> Components: test-suite
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.1-incubating
>
>
> There are a number of tests that need to use the file system to read/write
> input/output. Determining that directory to read/write from/to is currently
> done in a number of ways in different contexts in the test suite.
> The appropriate method is to use {{TestHelper}} to construct that path as it
> accounts for a number of environmental situations. {{TestHelper}} could use
> some additional work to improve it's usage - maybe it needs its own unit
> tests as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
