[ 
https://issues.apache.org/jira/browse/TINKERPOP-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102808#comment-15102808
 ] 

ASF GitHub Bot commented on TINKERPOP-1086:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/203

    TINKERPOP-1086 Added gryo serializers for virtually all java.time classes.

    These classes did not have serializers native to kryo and were also not in 
the semi-standard contrib package of serializers.  GraphSON serialization works 
out of the box with `FieldSerializer` - it's verbose output for JSON but I 
dont' think we need to build special serializers for that yet.
    
    Ran both unit and integration tests successfully.  Also did a manual test 
in the console via `:remote`:
    
    ```text
    gremlin> :> java.time.Instant.now()
    ==>2016-01-15T19:39:16.569Z
    gremlin> :> java.time.Duration.ZERO
    ==>PT0S
    gremlin> :> java.time.Duration.ofDays(10)
    ==>PT240H
    ```
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1086

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/203.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #203
    
----
commit 74b4c6186158037b20593a12e9b7ed4105632be1
Author: Stephen Mallette <[email protected]>
Date:   2016-01-16T00:51:39Z

    Added gryo serializers for virtually all java.time classes.
    
    These classes did not have serializers natively to kryo and were also not 
in the semi-standard contrib package of serializers.

----


> Include gryo serializers for java.time related classes
> ------------------------------------------------------
>
>                 Key: TINKERPOP-1086
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1086
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 3.1.0-incubating
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Minor
>             Fix For: 3.1.1-incubating
>
>
> The {{java.time}} classes are commonly used but not under standard 
> serialization with kryo. Develop serializers for the more commonly used 
> classes from that package.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to