[ 
https://issues.apache.org/jira/browse/TINKERPOP-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107689#comment-15107689
 ] 

ASF GitHub Bot commented on TINKERPOP-1089:
-------------------------------------------

Github user dkuppitz commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/204#issuecomment-173026342
  
    * `mvn clean install`: passed
    * `integration tests`: passed
    * `manual test`: passed
    
    Code looks good.
    
    VOTE: +1


> Order.shuffle implementation is too fragile
> -------------------------------------------
>
>                 Key: TINKERPOP-1089
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1089
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: process
>    Affects Versions: 3.0.2-incubating
>            Reporter: Daniel Kuppitz
>            Assignee: Marko A. Rodriguez
>             Fix For: 3.1.1-incubating
>
>
> {code}
> __((1..100).toList()).order(local).by(shuffle)
> {code}
> Try that query often enough and it will fail. You can increase the likeliness 
> of a failure by increasing the size of the list. An explanation of why that 
> happens is given here:
> http://stackoverflow.com/questions/19325256/java-lang-illegalargumentexception-comparison-method-violates-its-general-contr



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to