[
https://issues.apache.org/jira/browse/TINKERPOP-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139251#comment-15139251
]
ASF GitHub Bot commented on TINKERPOP-1138:
-------------------------------------------
GitHub user spmallette opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/217
TINKERPOP-1138 Improve messaging on server timeouts
https://issues.apache.org/jira/browse/TINKERPOP-1138
Provide distinct messaging for the different kinds of timeouts that Gremlin
Server can generate.
Tested with: `mvn clean install && mvn verify -pl gremlin-server
-DskipIntegrationTests=false`
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1138
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/217.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #217
----
commit 89e159b8bf9d4d6bcf6fc392dceb6c7eba33cf51
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-02-08T21:09:51Z
Improved messaging from gremlin server around timeouts.
There are multiple timeouts configurable in gremlin server and it wasn't
always clear which was triggering given the error messages that were being
generated. Improved the clarity in server-side logging and in the messages
returned to the client.
commit bad3af7ca2c57057995c4fb7f183bdc41f41ff72
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-02-09T16:58:23Z
Merge remote-tracking branch 'origin/tp31' into TINKERPOP-1138
commit 330c521dc652582d2525419cedb2748ec0291be4
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-02-09T17:00:35Z
Update changelog.
----
> Improve messaging on server timeouts
> ------------------------------------
>
> Key: TINKERPOP-1138
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1138
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.1.0-incubating
> Reporter: stephen mallette
> Assignee: stephen mallette
> Priority: Minor
> Fix For: 3.1.2-incubating
>
>
> There are several timeouts that Gremlin Server can encounter and the current
> messages that users receive don't always make it clear which one was raised,
> which then makes it hard to figure out how to resolve the exception.
> Improve logging and returned messages for these three settings:
> * {{scriptEvaluationTimeout}} - how long a script can be eval'd for
> * {{serializedResponseTimeout}} - how long the result of a script can
> iterate/serialize for
> * config to {{TimedInterruptCustomizerProvider}} - how long loops internal to
> a script can iterate for (related to {{scriptEvaluationTimeout}} in a sense
> as it times something similar)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
