Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/219#issuecomment-182005702
I was looking more into this. I think we should `Deprecate`
ScriptElementFactory. Why not just use `StarGraph` directly? Your
`vertex()`-logic is identical to `StarGraph.addVertex()`. Note that if its the
`StarVertex`, it comes right back. If its not a new `StarAdjacentVertex` is
created and returned.
I would recommend.
1. Do not add more methods to `ScriptElementFactory`.
2. Deprecate `ScriptElementFactory` in TP 3.2.0.
3. Update to use `StarGraph` directly, but if the user's script has a
method for `ScriptElementFactory`, then use that method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
