[ 
https://issues.apache.org/jira/browse/TINKERPOP-971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139768#comment-15139768
 ] 

ASF GitHub Bot commented on TINKERPOP-971:
------------------------------------------

Github user okram commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/215#issuecomment-182069459
  
    ```
    [INFO] 
------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] 
------------------------------------------------------------------------
    [INFO] Total time: 3:16:47.194s
    [INFO] Finished at: Tue Feb 09 14:06:43 MST 2016
    [INFO] Final Memory: 96M/731M
    [INFO] 
------------------------------------------------------------------------
    ```


> TraversalSource should be fluent like GraphComputer
> ---------------------------------------------------
>
>                 Key: TINKERPOP-971
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-971
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.1.0-incubating
>            Reporter: Marko A. Rodriguez
>            Assignee: Marko A. Rodriguez
>              Labels: breaking
>             Fix For: 3.2.0-incubating
>
>
> I just realized something so obvious. {{TraversalSource}} should be fluent 
> and not this awkward {{TraversalSource.Builder}} model we use. You should be 
> able to do this:
> {code}
> graph = GraphFactory.open(...)
> g = graph.traversal()
> g = g.withStrategy(MyStrategy.class)
> g = g.withSack(1.0,sum)
> ...
> g.V().out().sack()
> g.V().out().out().drop()
> {code}
> Thus, {{TraversalSource}} methods return a {{TraversalSource}}. 
> {code}
> g = 
> graph.traversal(computer(GiraphGraphComputer)).withStrategy(MyStrategy.class).withSack(1.0,sum).withBulk(false)
> {code}
> That {{g}} is then "locked" with those parameterizations and any 
> {{V()}}/{{addV()}}/etc. off of it will spawn traversal with that 
> parameterization.
> This solves:
>   TINKERPOP3-862
>   TINKERPOP3-960 (makes more elegant)
> This would be backwards compatible. Though, deprecation would occur.
> Finally, DSLs are still respected.
> {code}
> g = graph.traversal(SocialTraversal.class)
> {code}
> A fleeting thought...
> {code}
> g = graph.traversal().using(GiraphGraphComputer)
> g = graph.traversal().via(GremlinServerConnection).using(GiraphGraphComputer)
> {code}
> So much cleaner than all that {{Builder}}-crap....



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to