[ 
https://issues.apache.org/jira/browse/TINKERPOP-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141545#comment-15141545
 ] 

ASF GitHub Bot commented on TINKERPOP-1146:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/223

    TINKERPOP-1146 Use GraphProvider.clear() to auto-clear graphs created in 
tests

    https://issues.apache.org/jira/browse/TINKERPOP-1146
    
    Was formerly just calling `Graph.close()` which wasn't enough to actually 
empty graphs of data. This led to test errors for some graph providers.  This 
change actually calls `GraphProvider.clear()` which by definition should empty 
a graph of data at the end of a test.
    
    To test you technically need a graph that is persistent (e.g. Neo4j). Ran 
`mvn clean install -DincludeNeo4j` without problems.
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1146

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #223
    
----
commit 597c350459cf0ade1791180b0660d415064e17c4
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-02-10T19:51:20Z

    Use GraphProvider.clear() to auto-clear graphs created in tests
    
    Was formerlly just calling Graph.close() which wasn't enough to actually 
empty graphs of data. This led to test errors for some graph providers.  This 
change actually calls GraphProvider.clear() which by definition should empty a 
graph of data at the end of a test.

----


> IoTest are not clearing the db after the test run
> -------------------------------------------------
>
>                 Key: TINKERPOP-1146
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1146
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: test-suite
>    Affects Versions: 3.1.1-incubating
>            Reporter: pieter martin
>
> {{IoTest.shouldReadWriteSelfLoopingEdges}} are not clearing the db after the 
> test run.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to