[ 
https://issues.apache.org/jira/browse/TINKERPOP-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15144560#comment-15144560
 ] 

ASF GitHub Bot commented on TINKERPOP-1135:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/225

    TINKERPOP-1135 Improved GraphSON support of java.time.* packages.

    https://issues.apache.org/jira/browse/TINKERPOP-1135
    
    Serialized all classes currently serialized by Gryo using ISO-8061 format.  
Using the embedded type option actually allows serialization back to 
`java.time.*` classes rather than coercing them to other types. 
    
    All good with `mvn clean install && mvn verify -pl gremlin-server 
-DskipIntegrationTests=false`
    
    VOTE +1
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP-1135

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/225.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #225
    
----
commit cee96fdb29fe354837845da961c0f6252e007b5a
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2016-02-12T13:11:42Z

    Improved GraphSON support of java.time.* packages.
    
    Serialized all classes currently serialized by Gryo using ISO-8061 format.  
Using the embedded type option actually allow serialization back to java.time.* 
classes rather than coercing them to other types.

----


> Improve GraphSON representation of java.time.* classes
> ------------------------------------------------------
>
>                 Key: TINKERPOP-1135
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1135
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 3.1.1-incubating
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>             Fix For: 3.1.2-incubating
>
>
> Currently the {{java.time}} classes use the default field serializer which 
> generates stuff like this (e.g. for {{Instant}}): 
> {code}
> {"nano":657000000,"epochSecond":1454552791}
> {code}
> it would be nicer if we just did ISO-8061 in this case:
> {code}
> 2016-02-04T02:26:31.657Z
> {code}
> Do nicer/smarter things for other classes as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to