[ 
https://issues.apache.org/jira/browse/TINKERPOP-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152988#comment-15152988
 ] 

ASF GitHub Bot commented on TINKERPOP-1041:
-------------------------------------------

Github user pluradj commented on the pull request:

    
https://github.com/apache/incubator-tinkerpop/pull/209#issuecomment-185893011
  
    I voted +1 a few days ago.
    
    The changes for appveyor since then look fine too. I added a windows 
profile in the `spark-gremlin/pom.xml` to exclude the same tests as appveyor, 
`mvn clean install` on a local Windows build. I tested with Windows 7.
    
    ```
    mvn clean install
    [INFO] 
------------------------------------------------------------------------
    [INFO] Reactor Summary:
    [INFO]
    [INFO] Apache TinkerPop ................................... SUCCESS [ 
12.979 s]
    [INFO] Apache TinkerPop :: Gremlin Shaded ................. SUCCESS [  
5.288 s]
    [INFO] Apache TinkerPop :: Gremlin Core ................... SUCCESS [ 
45.655 s]
    [INFO] Apache TinkerPop :: Gremlin Test ................... SUCCESS [ 
20.554 s]
    [INFO] Apache TinkerPop :: Gremlin Groovy ................. SUCCESS [01:10 
min]
    [INFO] Apache TinkerPop :: Gremlin Groovy Test ............ SUCCESS [ 
11.831 s]
    [INFO] Apache TinkerPop :: TinkerGraph Gremlin ............ SUCCESS [01:58 
min]
    [INFO] Apache TinkerPop :: Hadoop Gremlin ................. SUCCESS [07:21 
min]
    [INFO] Apache TinkerPop :: Spark Gremlin .................. SUCCESS [01:12 
min]
    [INFO] Apache TinkerPop :: Giraph Gremlin ................. SUCCESS [ 
16.402 s]
    [INFO] Apache TinkerPop :: Neo4j Gremlin .................. SUCCESS [  
8.352 s]
    [INFO] Apache TinkerPop :: Gremlin Driver ................. SUCCESS [ 
13.021 s]
    [INFO] Apache TinkerPop :: Gremlin Server ................. SUCCESS [ 
12.301 s]
    [INFO] Apache TinkerPop :: Gremlin Console ................ SUCCESS [ 
22.349 s]
    [INFO] 
------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] 
------------------------------------------------------------------------
    [INFO] Total time: 14:31 min
    [INFO] Finished at: 2016-02-18T14:46:07-05:00
    [INFO] Final Memory: 148M/2211M
    [INFO] 
------------------------------------------------------------------------
    ```


> StructureStandardTestSuite has file I/O issues on Windows
> ---------------------------------------------------------
>
>                 Key: TINKERPOP-1041
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1041
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: test-suite
>    Affects Versions: 3.0.2-incubating
>         Environment: Windows 10, Java 8, TinkerPop version "3.0.2-incubating"
>            Reporter: Martin Häusler
>            Assignee: Jason Plurad
>             Fix For: 3.1.2-incubating
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> Most of the tests in StructureStandardTestSuite/IoGraphTest cause an 
> unexpected java.io.IOException. The stack trace looks like this:
> {panel:title=Stack Trace}
> java.io.IOException: The the file name, directory name or volume label syntax 
> is incorrect.
>       at java.io.WinNTFileSystem.createFileExclusively(Native Method)
>       at java.io.File.createTempFile(Unknown Source)
>       at 
> org.apache.tinkerpop.gremlin.TestHelper.generateTempFile(TestHelper.java:74)
>       at 
> org.apache.tinkerpop.gremlin.structure.io.IoGraphTest.shouldReadWriteModernToFileWithHelpers(IoGraphTest.java:164)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>       at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>       at java.lang.reflect.Method.invoke(Unknown Source)
> {panel}
> I'm running the test suite from Eclipse under Java 8, on a Windows 10 x64 
> machine. The dependencies in my project are managed with gradle. 
> Investigating the offinsive line 
> (org.apache.tinkerpop.gremlin.TestHelper.java@74) in the debugger reveals the 
> following parameters of "File.createTempFile(...)":
> {noformat}
> fileName = "shouldReadWriteModernToFileWithHelpers[graphml]"
> fileNameSuffix = ".xml"
> path = 
> "file:\D:\guh\caches\modules-2\files-2.1\org.apache.tinkerpop\gremlin-test\3.0.2-incubating\345ec87b74923b76374111f2e4040d4d105f256\temp"
> {noformat}
> The offensive part is the "path" variable, because it contains the prefix 
> "file:\". I tried the same thing in a dedicated JUnit test without the prefix 
> and it works fine.
> I would be very happy to see this issue fixed, as this considerably reduces 
> the amount of tests in the suite that I can run against my graph 
> implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to