[ https://issues.apache.org/jira/browse/TINKERPOP-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154277#comment-15154277 ]
ASF GitHub Bot commented on TINKERPOP-1151: ------------------------------------------- Github user spmallette commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/229#issuecomment-186237810 I guess we shouldn't have log4j be a standard dependency for `gremlin-core`, given use of slf4j, but I'm not sure making it a test dependency is right. we package log4j by default in the `gremlin-console` and `gremlin-server`. maybe those slf4j implementations should be added to those project directly and they are made a test dependency here? > slf4j-log4j12 / log4j is only required for testing > -------------------------------------------------- > > Key: TINKERPOP-1151 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1151 > Project: TinkerPop > Issue Type: Bug > Components: io > Affects Versions: 3.1.0-incubating > Reporter: Hendy Irawan > Priority: Trivial > > Pull request: https://github.com/apache/incubator-tinkerpop/pull/229 -- This message was sent by Atlassian JIRA (v6.3.4#6332)